Hi, I am having a bit of a problem, my code reads from a .txt file with the data:

TTFTFTTTFTFTFFTTFTTF
ABC54102 T FTFTFTTTFTTFTTF TF
DEF56278 TTFTFTTTFTFTFFTTFTTF
ABC42366 TTFTFTTTFTFTFFTTF
ABC42586 TTTTFTTT TFTFFFTF

The first line is a set of True/False correct answer, the second through fifth line consists of a student number followed by a blank space followed by a set of student answers, there are three marking principles. Correct, incorrect and blank.

For some reason when i print out each member as it is assigned to the correct answer char array it is as per the txt document but when i run the "testScore" function member [0] for correctAnswers is assigned as '6'. Please see code below (i have added some code after the function call to show what the array output is).

#include <iostream>
#include <fstream>

using namespace std;

const int STUDENT_NUMBER_LGTH = 8;
const int NUMBER_QUESTIONS = 20;
const int NUMBER_STUDENTS = 4;

const int ANSWER_CORRECT = 2;
const int ANSWER_INCORRECT = -1;
const int ANSWER_BLANK = 0;

void getData(ifstream& inputFile, char correctAns[], char studentNo[][STUDENT_NUMBER_LGTH], char studentAns[][NUMBER_QUESTIONS]);
void testScore(char correctAns[], char studentAns[][NUMBER_QUESTIONS], int finScore[]);

int main()
{
char correctAnswers[NUMBER_QUESTIONS];
char studentNumber[NUMBER_STUDENTS][STUDENT_NUMBER_LGTH];
char studentAnswers[NUMBER_STUDENTS][NUMBER_QUESTIONS];

int finalScore[NUMBER_STUDENTS];

ifstream inFile;

inFile.open("Ex2_Data.txt");

getData(inFile, correctAnswers, studentNumber, studentAnswers);
testScore(correctAnswers, studentAnswers, finalScore);

int student1;
int studentNumber1;
int questionNumber1;
int answerNumber1;

for (answerNumber1 = 0; answerNumber1 < NUMBER_QUESTIONS; answerNumber1++)
{
cout << correctAnswers[answerNumber1];
}

cout << endl;

for (student1 = 0; student1 < NUMBER_STUDENTS; student1++)
{
for (studentNumber1 = 0; studentNumber1 < STUDENT_NUMBER_LGTH; studentNumber1++)
{
cout << studentNumber[student1][studentNumber1];
}

cout << " ";

for (questionNumber1 = 0; questionNumber1 < NUMBER_QUESTIONS; questionNumber1++)
{
cout << studentAnswers[student1][questionNumber1];
}
}

inFile.close();

return 0;
}

void getData(ifstream& inputFile, char correctAns[], char studentNo[][STUDENT_NUMBER_LGTH], char studentAns[][NUMBER_QUESTIONS])
{
int student;
int studentNumberDigit;
int questionNumber;
int studentAnswerNumber;
char disregard;

for (questionNumber = 0; questionNumber < NUMBER_QUESTIONS; questionNumber++)
{
inputFile.get(correctAns[questionNumber]);
}

for (student = 0; student < NUMBER_STUDENTS; student++)
{
for (studentNumberDigit = 0; studentNumberDigit <= STUDENT_NUMBER_LGTH; studentNumberDigit++)
{
inputFile.get(studentNo[student][studentNumberDigit]);
}

inputFile.get(disregard);

for (studentAnswerNumber = 0; studentAnswerNumber < NUMBER_QUESTIONS; studentAnswerNumber++)
{
inputFile.get(studentAns[student][studentAnswerNumber]);
}
}
}

void testScore(char correctAns[], char studentAns[][NUMBER_QUESTIONS], int finScore[])
{
int student;
int questionNumber;
int finalScore;

for (student = 0; student < NUMBER_STUDENTS; student++)
{
finalScore = 0;

for (questionNumber = 0; questionNumber < NUMBER_QUESTIONS; questionNumber++)
{
if (studentAns[student][questionNumber] == correctAns[questionNumber])
{
finalScore += ANSWER_CORRECT;
}
else if (studentAns[student][questionNumber] == ' ')
{
finalScore += ANSWER_BLANK;
}
else
{
finalScore += ANSWER_INCORRECT;
}
}

}
}

When posting code, please use code tags so that the code is readable!




You're not dealing with student answers that have less answers than the number of questions. Consider:





PS Have you come to std::string yet? Using this rather than char arrays makes things much easier...