writing flighting system
so i need to write a flighting system , ask name then what number between 1 - 5 and each number has a specific time, how would I write the loop for it to display lets say I write (2) then it must give number (2)'s time above etc?
|
|
Hello Anonomys,
First look at your program:
The indenting is terrible as in not easy to read.
As you will see you do not need a "cout" and "endl" for every line, Lines in double quotes become 1 big string and the insertion operator (<<) can chain more than 1 item into 1 "cout".
On line 13 you are asking for a full name, but line 14 as formatted input will only read until a white space or new line is encountered, whichever comes first. Given a name of "Etienne Navarre" only "Etienne" will be stored in the variable "name" leaving the next "cin" to read what is left.
If you are wanting a full name that contains space(s) you need to use "std::getline()". In addition to "<string>" being needed for the "cin" and "cout" statements, "std::getline()" is defined in the string class.
This code is duplicate in every if statement. The only part I see that changes is the time.
You could set up the times in an array of strings and using the number input from the menu selection you can write the first line using a variable and you would only need the above code once. As an alternative a "switch" would also work, if you have studied "switch".
I have some ideas, but it will take me a bit to rework what you started with.
Also thinking a do/while or while loop is needed, but first get the program working.
Andy
First look at your program:
The indenting is terrible as in not easy to read.
As you will see you do not need a "cout" and "endl" for every line, Lines in double quotes become 1 big string and the insertion operator (<<) can chain more than 1 item into 1 "cout".
|
|
On line 13 you are asking for a full name, but line 14 as formatted input will only read until a white space or new line is encountered, whichever comes first. Given a name of "Etienne Navarre" only "Etienne" will be stored in the variable "name" leaving the next "cin" to read what is left.
If you are wanting a full name that contains space(s) you need to use "std::getline()". In addition to "<string>" being needed for the "cin" and "cout" statements, "std::getline()" is defined in the string class.
This code is duplicate in every if statement. The only part I see that changes is the time.
|
|
You could set up the times in an array of strings and using the number input from the menu selection you can write the first line using a variable and you would only need the above code once. As an alternative a "switch" would also work, if you have studied "switch".
I have some ideas, but it will take me a bit to rework what you started with.
Also thinking a do/while or while loop is needed, but first get the program working.
Andy
Hello Anonomys,
I noticed in your if statements you have
A rearrangement of your code to remove duplication:
Lines 57 - 63 can be copied and pasted for choices 2 - 5.
Line 64 is more for temporary use right now. When you add a do/while or while loop for most of main you will need an if statement for choice 6. A "continue" will bypass any code left and go to the while condition. Or a "break" statement will leave the loop.
I did have 1 question. Once you pick a seat how are you intending to deal with marking that seat taken?
Based on my code you could put lines 31 - 81 in a do/while or while loop. Personally I would use a do/while loop, but either will work.
Having the seats hard coded means they can not change at run time. This needs reworked. Maybe a 2D array or 2D vector would be better.
Possible output from above code is:
Notice the use of blank lines to break up the output. It makes it easier to read.
Andy
I noticed in your if statements you have
if (number = 1). (=) means to assign and (==) means to compare.A rearrangement of your code to remove duplication:
|
|
Lines 57 - 63 can be copied and pasted for choices 2 - 5.
Line 64 is more for temporary use right now. When you add a do/while or while loop for most of main you will need an if statement for choice 6. A "continue" will bypass any code left and go to the while condition. Or a "break" statement will leave the loop.
I did have 1 question. Once you pick a seat how are you intending to deal with marking that seat taken?
Based on my code you could put lines 31 - 81 in a do/while or while loop. Personally I would use a do/while loop, but either will work.
Having the seats hard coded means they can not change at run time. This needs reworked. Maybe a 2D array or 2D vector would be better.
Possible output from above code is:
Welcome to COS1511 Flight Booking System
Enter full name : Etienne Navarre
The available travel times for flights are:
Depart Arrive
1. 07.00 09.30
2. 09.00 11.30
3. 11.00 13.30
4. 13.00 15.30
5. 15.00 17.30
6. Exit
Enter choice: a
Invalid entry! Must be a number.
Enter choice: 0
Invalid choice! Try again.
Enter choice: 9
Invalid choice! Try again.
Enter choice: 2
The available seats for 09.00 are as follows:
First Class (1920.00)
|A1|A2|A3| - - - - |A4|A5|A6|
|B1|B2|B3| - - - - |B4|B5|B6|
|C1|C2|C3| - - - - |C4|C5|C6|
|D1|D2|D3| - - - - |D4|D5|D6|
|Economy class (1600.00)
|E1|E2|E3| - - - - |E4|E5|E6|
|F1|F2|F3| - - - - |F4|F5|F6|
|G1|G2|G3| - - - - |G4|G5|G6|
|H1|H2|H3| - - - - |H4|H5|H6|
|I1|I2|
Please Enter A Seat :
|
Notice the use of blank lines to break up the output. It makes it easier to read.
Andy
Hello Anonomys,
I think it is time to post the complete instructions for the program.
You are asking about a loop that you are not ready for yet.
The program needs some major thought about what you need to do.
What I am seeing is that you have 5 flights each with its own seating chart. That could mean a 3D array or an array of structs where the struct is a seating chart or 2D array of seats.
You would also need to check if a seat is already taken, someone might enter a wrong letter or number for a seat that may already be booked.
You would also need to keep track of the number of seats booked for a given flitht to know when a plane is full.
Not knowing what is called for these are just guesses for now.
Andy
I think it is time to post the complete instructions for the program.
You are asking about a loop that you are not ready for yet.
The program needs some major thought about what you need to do.
What I am seeing is that you have 5 flights each with its own seating chart. That could mean a 3D array or an array of structs where the struct is a seating chart or 2D array of seats.
You would also need to check if a seat is already taken, someone might enter a wrong letter or number for a seat that may already be booked.
You would also need to keep track of the number of seats booked for a given flitht to know when a plane is full.
Not knowing what is called for these are just guesses for now.
Andy
yes thank you @handy andy the above explanation helped a lot , I knew what i wanted to do but wasn't sure how to put it. the next step is if the seat is already taken then it must be indicated with "**" and if it has "**" then a message must display saying "Seat already taken , choose a new 1" untill it works and after that I just need to make a whole new message that looks like a full ticket with persons name , flight time , location , thanking him or her and the price it costed. I will try to start doing that and thank you again
|
|
This is how it looks atm , what I must do is the above Comments I typed in the code and then I just need to loop this WHOLE code. So lets say it gives that ticket I just made at the end then it must make an "**" at the BOOKED seat that was previously booked and then a prompt question must come saying "Do you want another booking" if its "YES" then the whole thing starts over and the booked seat is no more,and if a person wants to book the booked seat a message must come saying its already booked choose another.
also this would work?
|
|
I fixed it to look like this
|
|
Last edited on
Do I have to make Economy and First class x2 variables and then the range of each is A1 --> D6 and E1 --> I2? then if Economy == R1600.00 and if First Class == R1920.00?
Hello Anonomys,
Looking over your latest code gives me a better idea of what you need.
What I do not know is what you Ihave learned and what you can use.
I do not know if this will work for you, but I created a struct to contain a variable to keep track of the seats left and a 2D array of the seats.
Then in "main" I defined an array of the structs, so that each element corresponds to each of the flights. This way you can book a seat on any flight and the seat chosen will not affect any of the other flights.
I do not know if you can use functions yet, but I created a function that can print out the seats for any given flight.
At the moment it looks like this:
Not sure what you want to do with line "I", so I used the "##" to mark an unavailable seat. You could use something else or spaces, but it makes the output easier to work with. Plus you can use the contents of those elements when checking if someone entered the wrong seat.
Sorry about leaving the header file "<utility>". I had a thought at one time of using "std::pair", but decided against it as it was not needed. You can remove the header file "<utility>".
I added some variables in "main" and changed the if statements to:
Following the last if statement:
Line 13 changes a lower case letter to upper case if needed. It saves on check each case later.
Let me know what you can use and I will see what I can come up with.
For now work in small steps and do not try to do everything at once or you may never get done in time. Compile often and test what you have done.
Here is a little trick to make things easier:
Once you know that the code for entering a name works this allows you to skip that part and move on to the menu and the rest of the program.
When finished you can delete the added code or just reverse the comments in case you need it later.
Andy
P.S. meant to mention that the if statements would work better as a switch if you can use that.
Looking over your latest code gives me a better idea of what you need.
What I do not know is what you Ihave learned and what you can use.
I do not know if this will work for you, but I created a struct to contain a variable to keep track of the seats left and a 2D array of the seats.
Then in "main" I defined an array of the structs, so that each element corresponds to each of the flights. This way you can book a seat on any flight and the seat chosen will not affect any of the other flights.
I do not know if you can use functions yet, but I created a function that can print out the seats for any given flight.
At the moment it looks like this:
Welcome to COS1511 Flight Booking System
Enter full name: Etienne Navarre
The available travel times for flights are:
Depart Arrive
1. 07.00 09.30
2. 09.00 11.30
3. 11.00 13.30
4. 13.00 15.30
5. 15.00 17.30
6. Exit
Enter choice: 2
The available seats for departure time of 09.00 are as follows:
First Class (1920.00):
|A1|A2|A3| - - - - |A4|A5|A6|
|B1|B2|B3| - - - - |B4|B5|B6|
|C1|C2|C3| - - - - |C4|C5|C6|
|D1|D2|D3| - - - - |D4|D5|D6|
Economy class (1600.00):
|E1|E2|E3| - - - - |E4|E5|E6|
|F1|F2|F3| - - - - |F4|F5|F6|
|G1|G2|G3| - - - - |G4|G5|G6|
|H1|H2|H3| - - - - |H4|H5|H6|
|I1|I2|##| - - - - |##|##|##|
There are 50 left on the plane.
Please Enter A Seat: e3
The available seats for departure time of 09.00 are as follows:
First Class (1920.00):
|A1|A2|A3| - - - - |A4|A5|A6|
|B1|B2|B3| - - - - |B4|B5|B6|
|C1|C2|C3| - - - - |C4|C5|C6|
|D1|D2|D3| - - - - |D4|D5|D6|
Economy class (1600.00):
|E1|E2|**| - - - - |E4|E5|E6|
|F1|F2|F3| - - - - |F4|F5|F6|
|G1|G2|G3| - - - - |G4|G5|G6|
|H1|H2|H3| - - - - |H4|H5|H6|
|I1|I2|##| - - - - |##|##|##|
There are 49 left on the plane.
Press Enter to continue:
|
Not sure what you want to do with line "I", so I used the "##" to mark an unavailable seat. You could use something else or spaces, but it makes the output easier to work with. Plus you can use the contents of those elements when checking if someone entered the wrong seat.
Sorry about leaving the header file "<utility>". I had a thought at one time of using "std::pair", but decided against it as it was not needed. You can remove the header file "<utility>".
I added some variables in "main" and changed the if statements to:
|
|
Following the last if statement:
|
|
Line 13 changes a lower case letter to upper case if needed. It saves on check each case later.
Let me know what you can use and I will see what I can come up with.
For now work in small steps and do not try to do everything at once or you may never get done in time. Compile often and test what you have done.
Here is a little trick to make things easier:
|
|
Once you know that the code for entering a name works this allows you to skip that part and move on to the menu and the rest of the program.
When finished you can delete the added code or just reverse the comments in case you need it later.
Andy
P.S. meant to mention that the if statements would work better as a switch if you can use that.
Last edited on
Are you allowed to use things like classes and vectors?
Or are you limited to arrays?
Functions to display a flight, book a seat or check a seat is available would all have the same basic signature of
Eg
Could be called from main as
Or are you limited to arrays?
|
|
Functions to display a flight, book a seat or check a seat is available would all have the same basic signature of
|
|
Eg
|
|
Could be called from main as
|
|
To explain it easier , this is what must be done
|
|
Last edited on
Hello Anonomys,
Your code is a start, but needs major work to cover what you have said do far.
I am guessing that this is a school assignment?
If so you were given instructions of what the program should do and maybe what is expected to be used in the program. Or what can not be used in the program.
By not posting the instructions you are leaving yourself open to suggestions that are beyond what you know.
I wish I could say that your last code is a good start, but I can not because it is missing to many parts. Functions help a great deal if you can use them.
You have no way to mark or keep track of what seat has been booked, how many seats are left or if the plane is full.
The code says there are 5 different flights and each flight could have different seats booked. There is no way to keep track of this with the code that you have.
The program needs better planning instead of posting some code and asking how do I make this work.
Tell us what you have learned and what you can use, so that everyone will know what to work with.
Andy
Your code is a start, but needs major work to cover what you have said do far.
I am guessing that this is a school assignment?
If so you were given instructions of what the program should do and maybe what is expected to be used in the program. Or what can not be used in the program.
By not posting the instructions you are leaving yourself open to suggestions that are beyond what you know.
I wish I could say that your last code is a good start, but I can not because it is missing to many parts. Functions help a great deal if you can use them.
You have no way to mark or keep track of what seat has been booked, how many seats are left or if the plane is full.
The code says there are 5 different flights and each flight could have different seats booked. There is no way to keep track of this with the code that you have.
The program needs better planning instead of posting some code and asking how do I make this work.
Tell us what you have learned and what you can use, so that everyone will know what to work with.
Andy
To emphasise some points that Andu has made. Always design your program before you start to code. You should 'code from design' not 'code as design'. In cases like this as a minimum the design should detail the output, the input, the data structures used, a breakdown of the program into steps (and functions/classes if used) and the overall 'flow' through the program (how it's going to work at a high level).
Hello, thank you for the replies , its hard to say what I learned and what not since this module I learn c++ (beginners) and my next module its c++ that you must already know the beginner ( a bit more advanced, i did use vectors in my prev assignment code which we don't learn and doesn't look like it was a problem)
but
whats usable is
2 dimensional array
1 dimensional array
void function with value parameters
if loop
switch
do while
while loop
for loop
use of array as function
im not sure if we do strings but i did also use that on prev assignments
but
whats usable is
2 dimensional array
1 dimensional array
void function with value parameters
if loop
switch
do while
while loop
for loop
use of array as function
im not sure if we do strings but i did also use that on prev assignments
Here's a working flight booking system.
I've limited it to using structs (which you don't mention) and arrays.
I don't normally encourage the use of globals, but I've made SeatMap and Flights global because they're used by nearly every function.
Please note the extensive use of named constants which eliminate the need to change values in multiple places in the program.
You may want to tweak the appearance of the ticket.
I've broken the program into numerous functions which are small and easy to understand.
You should have no problem extending the program if you want or need to.
Some changes I would make:
- I would allow the cost of first class and economy seats vary by flight.
- I would keep track of the total revenue for each flight as well as the grand total.
- I would make the departure and arrival cities attributes of the Flights struct so that flights between different citties can be handled.
edit: Fixed line 232
I've limited it to using structs (which you don't mention) and arrays.
I don't normally encourage the use of globals, but I've made SeatMap and Flights global because they're used by nearly every function.
Please note the extensive use of named constants which eliminate the need to change values in multiple places in the program.
You may want to tweak the appearance of the ticket.
I've broken the program into numerous functions which are small and easy to understand.
You should have no problem extending the program if you want or need to.
Some changes I would make:
- I would allow the cost of first class and economy seats vary by flight.
- I would keep track of the total revenue for each flight as well as the grand total.
- I would make the departure and arrival cities attributes of the Flights struct so that flights between different citties can be handled.
|
|
edit: Fixed line 232
Last edited on
@AbstractionAnon that is EXACTLY what I wanted to do , thank you really much , i'll work on it to try and understand everything you did but for the basics i got it. Thank you again.
also i noticed
works instead of
and 1 last thing , the counting system at the end it doesn't count lets say they choose flight 1 like 3 times then it only counts it as one for some reason
also i noticed
|
|
|
|
and 1 last thing , the counting system at the end it doesn't count lets say they choose flight 1 like 3 times then it only counts it as one for some reason
Last edited on
std::cin works as long as there are no spaces in the input, that's why std::getline is used. For example, if one's family name is Di Masi, std::cin will only read "Di"
the counting system at the end it doesn't count lets say they choose flight 1 like 3 times then it only counts it as one for some reason |
I'm not seeing that. See lines 156-157. When the seat is marked reserved, the counter is incremented. I booked 3 seats and got the following display:
|
|
What I did notice is the flight numbers need to be incremented in the cout statement so so they display as 1-5. Line 232 should be:
|
|
ah sorry @AbstractionAnon I edited out
for (int f = 0; f < MAX_FLIGHTS; f++) thats why it didn't work :P sorry
Topic archived. No new replies allowed.