Tic-Tac-Toe Engine Bug.
Trying to make a Tic-Tac-Toe engine with smart computer
Most things are explained in the code.
2 Player mode works just fine, 1 player mode against computer that plays randomly is fine too.
But after implementing code that helps the computer find a square that will cause it to lose and blocking it, problems started to appear.
1. The first time it encounters danger, it blocks just fine, but if it happens a second time, it does nothing.
2. If X has 2 squares in a row, but an O is blocking it's path, the computer will nevertheless try to put a O there.
(The code is too long, splitting it into 3 parts)
Most things are explained in the code.
2 Player mode works just fine, 1 player mode against computer that plays randomly is fine too.
But after implementing code that helps the computer find a square that will cause it to lose and blocking it, problems started to appear.
1. The first time it encounters danger, it blocks just fine, but if it happens a second time, it does nothing.
2. If X has 2 squares in a row, but an O is blocking it's path, the computer will nevertheless try to put a O there.
(The code is too long, splitting it into 3 parts)
|
|
Last edited on
|
|
Last edited on
|
|
First post:
Line 20: initialize win=0 and change=0
Lines 58-115: You can simplify this to:
Second post:
Line 4 is not needed.
Third post:
Lines 7-9. The second time it's the computer's move, random will be whatever move value you had on the previous turn. The code works but it's fragile. I'd move line 26 of the first post down here.
Lines 10-36: you select a blocking square, but what if that square is already occupied? This is why it isn't selecting the right blocking move on the 2nd turn.
General:
- You only check for a winner after both the player and computer have had a move. What if the player wins after his move?
- Along the same lines, if the player takes the last square, then you'll still try to compute a move for the computer, which will probably result in an infinite loop as the computer tries to find an empty square. The outer loop should look like this:
Notice the long switch statements and all the code to update the board string? You're making a common mistake by combining the display of the date (your board string) with the representation of the data. You don't actually need the board string at all. Instead, write a function to display the board based on the contents of the X and O arrays.
Line 20: initialize win=0 and change=0
Lines 58-115: You can simplify this to:
|
|
Second post:
Line 4 is not needed.
change is always 0 here because it's inside the if at line 55 of the first post.Third post:
Lines 7-9. The second time it's the computer's move, random will be whatever move value you had on the previous turn. The code works but it's fragile. I'd move line 26 of the first post down here.
Lines 10-36: you select a blocking square, but what if that square is already occupied? This is why it isn't selecting the right blocking move on the 2nd turn.
General:
- You only check for a winner after both the player and computer have had a move. What if the player wins after his move?
- Along the same lines, if the player takes the last square, then you'll still try to compute a move for the computer, which will probably result in an infinite loop as the computer tries to find an empty square. The outer loop should look like this:
|
|
Notice the long switch statements and all the code to update the board string? You're making a common mistake by combining the display of the date (your board string) with the representation of the data. You don't actually need the board string at all. Instead, write a function to display the board based on the contents of the X and O arrays.
Right, changed it to this:
But it works sometimes, and sometimes does not.
It sometimes picks another square, and sometimes just picks the same square as usual.
|
|
But it works sometimes, and sometimes does not.
It sometimes picks another square, and sometimes just picks the same square as usual.
C++ evaluates
is evaluated like this:
You need some parentheses like this:
&& before || so for example this: if((X[2] == 1 && X[3] == 1) || (X[4] == 1 && X[7] == 1) || (X[5] == 1 && X[9] == 1) && O[1] != 1){is evaluated like this:
|
|
You need some parentheses like this:
|
|
Topic archived. No new replies allowed.